Conversation
…the wrapper is assumed to be negligible because, under many calling conventions, an object containing two pointers is passed using two registers, just like two separate pointer arguments.
kazuho
added a commit
to h2o/h2o
that referenced
this pull request
Mar 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid UB by using a wrapper object to obtain SNI lazily. The cost of the wrapper is assumed to be negligible because, under many calling conventions, an object containing two pointers is passed using two registers, just like two separate pointer arguments.
See: h2o/h2o#3562.